mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940567499
########## streams/src/test/java/org/apache/kafka/streams/TopologyTest.java: ########## @@ -423,10 +423,8 @@ public void process(final Record<Object, Object> record) { } } } - @Deprecated // testing old PAPI @Test public void shouldNotAllowToAddGlobalStoreWithSourceNameEqualsProcessorName() { - when(globalStoreBuilder.name()).thenReturn("anyName"); Review Comment: Some require side cleanup, as we don't call `name()` again, but throw `TopologyException` earlier. So need to remove this (otherwise test fails with "unnecessary stubbing" error) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org