ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1948439772
##########
metadata/src/test/java/org/apache/kafka/image/ImageDowngradeTest.java:
##########
@@ -77,59 +77,6 @@ static ApiMessageAndVersion
metadataVersionRecord(MetadataVersion metadataVersio
setFeatureLevel(metadataVersion.featureLevel()), (short) 0);
}
- /**
- * Test downgrading to a MetadataVersion that doesn't support
FeatureLevelRecord.
- */
- @Test
- public void testPremodernVersion() {
- writeWithExpectedLosses(MetadataVersion.IBP_3_2_IV0,
- Collections.singletonList(
- "feature flag(s): foo.feature"),
- Arrays.asList(
- metadataVersionRecord(MetadataVersion.IBP_3_3_IV0),
- TEST_RECORDS.get(0),
- TEST_RECORDS.get(1),
- new ApiMessageAndVersion(new FeatureLevelRecord().
- setName("foo.feature").
- setFeatureLevel((short) 4), (short) 0)),
- Arrays.asList(
- TEST_RECORDS.get(0),
- TEST_RECORDS.get(1))
- );
- }
-
- /**
- * Test downgrading to a MetadataVersion that doesn't support
inControlledShutdown.
- */
- @Test
- public void testPreControlledShutdownStateVersion() {
Review Comment:
We now always have the controlled shutdown state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
