ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1949577245
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -1813,7 +1813,7 @@ class Partition(val topicPartition: TopicPartition,
private def submitAlterPartition(proposedIsrState: PendingPartitionChange):
CompletableFuture[LeaderAndIsr] = {
debug(s"Submitting ISR state change $proposedIsrState")
val future = alterIsrManager.submit(
- new TopicIdPartition(topicId.getOrElse(Uuid.ZERO_UUID), topicPartition),
+ new
org.apache.kafka.server.common.TopicIdPartition(topicId.getOrElse(throw new
IllegalStateException("Topic id not set")), topicPartition.partition),
Review Comment:
@dajac I agree with you, but I thought that should be done in a separate PR
as I think it will require some refactoring given the way various things
interact right now. And perhaps it can be done in trunk only (no backport to
4.0 required).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
