chia7712 commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1950084465
##########
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java:
##########
@@ -128,18 +126,6 @@ public void testReassignment() throws Exception {
executeAndVerifyReassignment();
}
- @ClusterTests({
- @ClusterTest(types = {Type.KRAFT, Type.CO_KRAFT}, metadataVersion =
IBP_3_3_IV0)
- })
- public void testReassignmentWithAlterPartitionDisabled() throws Exception {
- // Test reassignment when the IBP is on an older version which does
not use
- // the `AlterPartition` API. In this case, the controller will
register individual
- // watches for each reassigning partition so that the reassignment can
be
- // completed as soon as the ISR is expanded.
Review Comment:
> you're saying we can remove this test and we don't need any other
follow-up since the comment was for the zk controller. Right?
we are on the same page!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
