ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1950100652
##########
metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectoryTest.java:
##########
@@ -74,39 +73,21 @@ public void testReadFromEmptyConfiguration() throws
Exception {
try (BootstrapTestDirectory testDirectory = new
BootstrapTestDirectory().createDirectory()) {
assertEquals(BootstrapMetadata.fromVersion(MetadataVersion.latestProduction(),
"the default bootstrap"),
- new BootstrapDirectory(testDirectory.path(),
Optional.empty()).read());
- }
- }
-
- @Test
- public void testReadFromConfigurationWithAncientVersion() throws Exception
{
- try (BootstrapTestDirectory testDirectory = new
BootstrapTestDirectory().createDirectory()) {
-
assertEquals(BootstrapMetadata.fromVersion(MetadataVersion.MINIMUM_BOOTSTRAP_VERSION,
- "the minimum version bootstrap with metadata.version
3.3-IV0"),
- new BootstrapDirectory(testDirectory.path(),
Optional.of("3.0")).read());
- }
- }
-
- @Test
- public void testReadFromConfiguration() throws Exception {
Review Comment:
`testReadFromConfiguration` is the same as `testReadFromEmptyConfiguration`
once the `MetadataVersion` parameter is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
