ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1950212652


##########
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##########
@@ -380,7 +380,7 @@ public void 
testUpdateBrokerConfigNotAffectedByInvalidConfig() {
     @ClusterTest(
          // Must be at greater than 1MB per cleaner thread, set to 2M+2 so 
that we can set 2 cleaner threads.
          serverProperties = {@ClusterConfigProperty(key = 
"log.cleaner.dedupe.buffer.size", value = "2097154")},
-         metadataVersion = MetadataVersion.IBP_3_3_IV0
+         metadataVersion = MetadataVersion.IBP_3_9_IV0

Review Comment:
   Since we cannot use `MINIMUM_VERSION` (see my other comment), I picked a 
recent version so there is less chance of this code changing. If it's 
confusing, I can change it to `IBP_3_3_IV3`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to