ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1950210926
##########
metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectoryTest.java:
##########
@@ -81,18 +81,17 @@ public void testReadFromEmptyConfiguration() throws
Exception {
@Test
public void testReadFromConfigurationWithAncientVersion() throws Exception
{
try (BootstrapTestDirectory testDirectory = new
BootstrapTestDirectory().createDirectory()) {
-
assertEquals(BootstrapMetadata.fromVersion(MetadataVersion.MINIMUM_BOOTSTRAP_VERSION,
- "the minimum version bootstrap with metadata.version
3.3-IV0"),
+ assertThrows(IllegalArgumentException.class, () ->
new BootstrapDirectory(testDirectory.path(),
Optional.of("3.0")).read());
}
}
@Test
public void testReadFromConfiguration() throws Exception {
try (BootstrapTestDirectory testDirectory = new
BootstrapTestDirectory().createDirectory()) {
-
assertEquals(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_3_IV2,
- "the configured bootstrap with metadata.version 3.3-IV2"),
- new BootstrapDirectory(testDirectory.path(),
Optional.of("3.3-IV2")).read());
+
assertEquals(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_3_IV3,
+ "the configured bootstrap with metadata.version 3.3-IV3"),
+ new BootstrapDirectory(testDirectory.path(),
Optional.of("3.3-IV3")).read());
Review Comment:
I think the code you're referencing was removed in a subsequent commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
