frankvicky commented on code in PR #18844:
URL: https://github.com/apache/kafka/pull/18844#discussion_r1951969348
##########
core/src/test/scala/unit/kafka/docker/KafkaDockerWrapperTest.scala:
##########
@@ -133,7 +133,7 @@ class KafkaDockerWrapperTest {
val configsPath = Paths.get("/path/to/configs")
val envVars = Map("CLUSTER_ID" -> "MYwKGPhXQZidgd0qMv8Mkw")
- val expected = Array("format", "--cluster-id=MYwKGPhXQZidgd0qMv8Mkw",
"-c", "/path/to/configs/server.properties")
+ val expected = Array("format", "--cluster-id=MYwKGPhXQZidgd0qMv8Mkw",
"-c", "/path/to/configs/server.properties", "--standalone")
Review Comment:
Yes, this is indeed a problem since `controller.quorum.voters` is the key
property for the static quorum.
One easy solution that comes to my mind is to check the content of the
`controller.properties` file.
If `controller.quorum.voters` exists, we should assume users want to run in
static quorum mode.
However, it still does not solve the issue of determining which dynamic mode
the user wants to use in the dynamic quorum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
