chia7712 commented on code in PR #18844:
URL: https://github.com/apache/kafka/pull/18844#discussion_r1958415198
##########
core/src/test/scala/unit/kafka/docker/KafkaDockerWrapperTest.scala:
##########
@@ -133,7 +133,7 @@ class KafkaDockerWrapperTest {
val configsPath = Paths.get("/path/to/configs")
val envVars = Map("CLUSTER_ID" -> "MYwKGPhXQZidgd0qMv8Mkw")
- val expected = Array("format", "--cluster-id=MYwKGPhXQZidgd0qMv8Mkw",
"-c", "/path/to/configs/server.properties")
+ val expected = Array("format", "--cluster-id=MYwKGPhXQZidgd0qMv8Mkw",
"-c", "/path/to/configs/server.properties", "--standalone")
Review Comment:
The current Docker Hub documentation for Kafka is based on the use of static
voters. Since Kafka 4.0 utilizes dynamic voters, users following the doc of
docker hub may encounter unexpected behavior. Due to the limited time available
for the 4.0.0 release, a simple and quick solution is to revert to using static
voters within the Docker image. This can be achieved by adding a configuration
file with static voter definitions to the `kafka/docker` folder, keeping it
separate from the main `kafka/config` directory. This approach allows us to
encourage the use of dynamic voters in typical deployments while maintaining
compatibility within the Docker image.
cc @dajac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
