apoorvmittal10 commented on code in PR #18862:
URL: https://github.com/apache/kafka/pull/18862#discussion_r1952487855
##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -1035,7 +1067,7 @@ public void testSharePartitionKey() {
assertNotEquals(sharePartitionKey1, sharePartitionKey3);
assertNotEquals(sharePartitionKey1, sharePartitionKey4);
assertNotEquals(sharePartitionKey1, sharePartitionKey5);
- assertNotEquals(sharePartitionKey1, null);
+ assertNotEquals(null, sharePartitionKey1);
Review Comment:
My bad, was correcting and didn't think about that. Done.
##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -407,7 +427,7 @@ public void testShareSessionExpiration() {
ShareRequestMetadata reqMetadata1 = new
ShareRequestMetadata(Uuid.randomUuid(), ShareRequestMetadata.INITIAL_EPOCH);
ShareFetchContext session1context =
sharePartitionManager.newContext(groupId, session1req, EMPTY_PART_LIST,
reqMetadata1, false);
- assertEquals(session1context.getClass(), ShareSessionContext.class);
+ assertEquals(ShareSessionContext.class, session1context.getClass());
Review Comment:
Make sense, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
