apoorvmittal10 commented on code in PR #18862:
URL: https://github.com/apache/kafka/pull/18862#discussion_r1954308387
##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -2792,6 +2835,22 @@ public void testFetchMessagesRotatePartitions() {
validateRotatedMapEquals(partitionMaxBytes,
resultShareFetch.partitionMaxBytes(), 1);
}
+ private Timer systemTimerReaper() {
+ return new SystemTimerReaper(
+ TIMER_NAME_PREFIX + "-test-reaper",
+ new SystemTimer(TIMER_NAME_PREFIX + "-test-timer"));
+ }
+
+ private void assertNoReaperThreadsPendingClose() {
+ List<String> allThreads = Thread.getAllStackTraces()
Review Comment:
I renamed it to threads to avoid confusion, as the threads where further
filtered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]