lianetm commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1954578166


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManagerTest.java:
##########
@@ -663,7 +663,7 @@ public void 
testSameAssignmentReconciledAgainWithMissingTopic() {
         // stay in RECONCILING state, since an unresolved topic is assigned
         
membershipManager.onHeartbeatSuccess(createConsumerGroupHeartbeatResponse(assignment1,
 membershipManager.memberId()));
         assertEquals(MemberState.RECONCILING, membershipManager.state());
-        membershipManager.poll(time.milliseconds());
+        membershipManager.maybeReconcile(true);

Review Comment:
   Hey @frankvicky , is it maybe that you're trying to update the tests without 
this change in place? 
https://github.com/apache/kafka/pull/18737#discussion_r1952918176
   
   All this suggestion of updating the tests that do not need revocation is 
based on that change. I tried it locally and the test passes with 
maybeReconcile(false) as expected (good news!), just including the change from 
the comment to short-circuit only if revocations are needed of course.
   
   -- update
   even with all this in place, we also need to address @junrao 's comment 
https://github.com/apache/kafka/pull/18737#discussion_r1953524086 but let's 
follow-up on that one there
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to