frankvicky commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1954884546
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/PollEvent.java:
##########
@@ -16,12 +16,12 @@
*/
package org.apache.kafka.clients.consumer.internals.events;
-public class PollEvent extends ApplicationEvent {
+public class PollEvent extends CompletableApplicationEvent<Void> {
private final long pollTimeMs;
public PollEvent(final long pollTimeMs) {
- super(Type.POLL);
+ super(Type.POLL, Long.MAX_VALUE);
Review Comment:
IMO, it's crucial to wait for `allConsumed` to be completed, so I set it to
`Long.MAX_VALUE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
