mumrah commented on PR #18907: URL: https://github.com/apache/kafka/pull/18907#issuecomment-2661165220
Returning a list seems good to me. It lets the generator methods be a bit simpler. +1 to sample code David Arthur On Sat, Feb 15, 2025 at 14:38 Chia-Ping Tsai ***@***.***> wrote: > At some point we stopped using ClusterGenerator and switched to the list > of ClusterConfig-s, but did not remove the interface. > > Git blame shows that the error was my fault, and that is why I file the > ticket trying to cover my fault 🥲 > > Do you have any feedback about using List instead of ClusterGenerator? > IIRC, I preferred to use List due to fluent style. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/kafka/pull/18907#issuecomment-2661063175>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAANOTHPRDJGFA6JU5C54M32P6JU5AVCNFSM6AAAAABXFH45JSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGA3DGMJXGU> > . > You are receiving this because you commented.Message ID: > ***@***.***> > [image: chia7712]*chia7712* left a comment (apache/kafka#18907) > <https://github.com/apache/kafka/pull/18907#issuecomment-2661063175> > > At some point we stopped using ClusterGenerator and switched to the list > of ClusterConfig-s, but did not remove the interface. > > Git blame shows that the error was my fault, and that is why I file the > ticket trying to cover my fault 🥲 > > Do you have any feedback about using List instead of ClusterGenerator? > IIRC, I preferred to use List due to fluent style. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/kafka/pull/18907#issuecomment-2661063175>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAANOTHPRDJGFA6JU5C54M32P6JU5AVCNFSM6AAAAABXFH45JSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGA3DGMJXGU> > . > You are receiving this because you commented.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
