chia7712 commented on code in PR #18844:
URL: https://github.com/apache/kafka/pull/18844#discussion_r1963720494
##########
docker/jvm/Dockerfile:
##########
@@ -62,14 +66,19 @@ LABEL org.label-schema.name="kafka" \
RUN set -eux ; \
apk update ; \
apk upgrade ; \
- apk add --no-cache wget gcompat gpg gpg-agent procps bash; \
+ apk add --no-cache wget gcompat procps bash; \
mkdir opt/kafka; \
wget -nv -O kafka.tgz "$kafka_url"; \
- wget -nv -O kafka.tgz.asc "$kafka_url.asc"; \
+ if [ "$skip_signing" != "true" ]; then \
+ apk add --no-cache gpg gpg-agent; \
Review Comment:
why to add this comment?
##########
docker/native/Dockerfile:
##########
@@ -32,12 +33,16 @@ COPY native_command.sh native_command.sh
RUN mkdir $KAFKA_DIR; \
microdnf install wget; \
wget -nv -O kafka.tgz "$KAFKA_URL"; \
- wget -nv -O kafka.tgz.asc "$KAFKA_URL.asc"; \
+ if [ "$skip_signing" != "true" ]; then \
+ wget -nv -O kafka.tgz.asc "$KAFKA_URL.asc"; \
+ wget -nv -O KEYS https://downloads.apache.org/kafka/KEYS; \
+ microdnf install gpg; \
Review Comment:
ditto
##########
core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala:
##########
@@ -110,7 +110,7 @@ object KafkaDockerWrapper extends Logging {
case Some(str) => str
case None => throw new RuntimeException("CLUSTER_ID environment variable
is not set.")
}
- Array("format", "--cluster-id=" + clusterId, "-c",
s"${configsPath.toString}/server.properties", "--standalone")
+ Array("format", "--cluster-id=" + clusterId, "-c",
s"${configsPath.toString}/server.properties")
Review Comment:
please add comment to explain why we don't use dynamic voters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
