mumrah commented on code in PR #18770: URL: https://github.com/apache/kafka/pull/18770#discussion_r1966041807
########## .github/scripts/thread-dump.sh: ########## @@ -20,10 +20,12 @@ sleep $(($SLEEP_MINUTES*60)); echo "Timed out after $SLEEP_MINUTES minutes. Dumping threads now..." mkdir thread-dumps +touch thread-dumps/pids.txt Review Comment: Now that we are splitting the CI into parallel jobs, I wanted an easy way to test if one of them had a timeout. Rather than enumerating all the parallel jobs in an "if", I am downloading any thread dump artifacts and checking for this directory "thread-dumps" ``` - name: Download Thread Dumps uses: actions/download-artifact@v4 with: pattern: junit-thread-dumps-23-* path: thread-dumps merge-multiple: true - name: Check For Thread Dump id: check-for-thread-dump run: | find . if [ -d thread-dumps ]; then echo "Found 'thread-dumps' directory. Will not proceed with test catalog collation."; exit 1; fi ``` I place the "pids.txt" file there just to ensure the directory is included in the upload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org