chia7712 commented on code in PR #18770:
URL: https://github.com/apache/kafka/pull/18770#discussion_r1966585438
##########
build.gradle:
##########
@@ -578,45 +562,6 @@ subprojects {
finalizedBy("copyTestXml")
}
- task quarantinedTest(type: Test, dependsOn: compileJava) {
- // Disable caching and up-to-date for this task. We always want
quarantined tests
- // to run and never want to cache their results.
- outputs.upToDateWhen { false }
- outputs.cacheIf { false }
-
- maxParallelForks = maxTestForks
- ignoreFailures = userIgnoreFailures
-
- maxHeapSize = defaultMaxHeapSize
- jvmArgs = defaultJvmArgs
-
- // KAFKA-17433 Used by deflake.yml github action to repeat individual tests
- systemProperty("kafka.cluster.test.repeat",
project.findProperty("kafka.cluster.test.repeat"))
- systemProperty("kafka.test.catalog.file",
project.findProperty("kafka.test.catalog.file"))
- systemProperty("kafka.test.run.quarantined", "true")
-
- testLogging {
- events = userTestLoggingEvents ?: testLoggingEvents
- showStandardStreams = userShowStandardStreams ?: testShowStandardStreams
- exceptionFormat = testExceptionFormat
- displayGranularity = 0
- }
- logTestStdout.rehydrate(delegate, owner, this)()
-
- useJUnitPlatform {
- includeEngines 'junit-jupiter'
- }
-
- develocity {
- testRetry {
- maxRetries = userMaxQuarantineTestRetries
Review Comment:
@mumrah any feedback about this comment? I assume both
`maxQuarantineTestRetries` and `maxQuarantineTestRetryFailures` can be removed
from `deflaky.yaml`. Both `userMaxQuarantineTestRetries` and
`userMaxQuarantineTestRetryFailures` can be removed from `build.gradle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
