CalvinConfluent commented on code in PR #18952:
URL: https://github.com/apache/kafka/pull/18952#discussion_r1966276275
##########
tests/kafkatest/tests/client/truncation_test.py:
##########
@@ -112,7 +117,10 @@ def none_consumed(this, consumer):
pre_truncation_pos = consumer.current_position(tp)
- self.kafka.set_unclean_leader_election(self.TOPIC)
Review Comment:
Yes, it is simpler. The `unclean.leader.election.enable` has to be set
before an event that triggers the election. Because I enforce the event
sequence in this PR, it is too late to set the config in its original place. So
we need to set the config earlier. The option I choose is to set it during the
topic creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
