chia7712 commented on code in PR #18952:
URL: https://github.com/apache/kafka/pull/18952#discussion_r1966667621
##########
tests/kafkatest/tests/client/truncation_test.py:
##########
@@ -112,7 +117,10 @@ def none_consumed(this, consumer):
pre_truncation_pos = consumer.current_position(tp)
- self.kafka.set_unclean_leader_election(self.TOPIC)
Review Comment:
+1 to set the `unclean.leader.election.enable` earlier - otherwise, in ELR
mode, `self.kafka.start_node(node2)` does not trigger the unclean election as
`node2` is not in ISR.
BTW, it seems `set_unclean_leader_election` is not used anymore - should we
remove it in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
