[ 
https://issues.apache.org/jira/browse/KAFKA-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733372#comment-16733372
 ] 

Guozhang Wang commented on KAFKA-7785:
--------------------------------------

[~jlaskowski] PartitionGrouper interface is indeed public as it allows users to 
customize it via `StreamsConfig.PARTITION_GROUPER_CLASS_CONFIG`. As for 
`DefaultPartitionGrouper`, it is arguably better to be put into internals 
package, while I left it as public APIs to indicate users what would be the 
default behavior if they do not customize, and also as an "education hint" for 
them to implement their own. What cons do you see if we keep this class as 
public?

> Move DefaultPartitionGrouper (and PartitionGrouper) to 
> o.a.k.streams.processor.internals package
> ------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-7785
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7785
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>    Affects Versions: 2.1.0
>            Reporter: Jacek Laskowski
>            Priority: Minor
>
> Since {{DefaultPartitionGrouper}} is only for the purpose of the internal 
> {{StreamsPartitionAssignor}} it would make sense to have it in the 
> {{org.apache.kafka.streams.processor.internals}} package.
> I would also vote to move {{PartitionGrouper.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to