[ 
https://issues.apache.org/jira/browse/KAFKA-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733527#comment-16733527
 ] 

Jacek Laskowski commented on KAFKA-7785:
----------------------------------------

Thanks [~guozhang] for a very prompt reply. It all makes sense. The only "cons" 
is that PartitionGrouper and the default implementation are used internally 
only and although I could understand that the interface could be in public the 
default implementation is internal.

The task was more to suggest moving the default impl to internals where it 
belongs IMHO.

> Move DefaultPartitionGrouper (and PartitionGrouper) to 
> o.a.k.streams.processor.internals package
> ------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-7785
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7785
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>    Affects Versions: 2.1.0
>            Reporter: Jacek Laskowski
>            Priority: Minor
>
> Since {{DefaultPartitionGrouper}} is only for the purpose of the internal 
> {{StreamsPartitionAssignor}} it would make sense to have it in the 
> {{org.apache.kafka.streams.processor.internals}} package.
> I would also vote to move {{PartitionGrouper.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to