ShivsundarR commented on code in PR #18986:
URL: https://github.com/apache/kafka/pull/18986#discussion_r1969299960
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerHeartbeatRequestManagerTest.java:
##########
@@ -582,6 +582,11 @@ public void testHeartbeatResponseOnErrorHandling(final
Errors error, final boole
verify(backgroundEventHandler, never()).add(any());
assertNextHeartbeatTiming(0);
break;
+ case TOPIC_AUTHORIZATION_FAILED:
+ verify(backgroundEventHandler).add(any(ErrorEvent.class));
+ assertNextHeartbeatTiming(DEFAULT_RETRY_BACKOFF_MS);
+ verify(membershipManager, never()).transitionToFatal();
+ break;
Review Comment:
Hi @lianetm, for this test, the error codes from the `errorProvider` method
does not provide `TOPIC_AUTHORIZATION_FAILED`, so this case would never occur
in this test right.
I have raised a minor PR to add the same -
https://github.com/apache/kafka/pull/19024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
