frankvicky commented on code in PR #18983:
URL: https://github.com/apache/kafka/pull/18983#discussion_r1969948672
##########
clients/src/main/java/org/apache/kafka/clients/admin/AlterPartitionReassignmentsOptions.java:
##########
@@ -28,4 +28,25 @@
*/
@InterfaceStability.Evolving
public class AlterPartitionReassignmentsOptions extends
AbstractOptions<AlterPartitionReassignmentsOptions> {
+
+ private Boolean allowReplicationFactorChange = true;
+
+ /**
+ * Set the option indicating if the alter partition reassignments call
should be
+ * allowed to alter the replication factor of a partition.
+ * In cases where it is not allowed, any replication factor change will
result in an exception thrown by the API.
+ */
Review Comment:
The javadoc is almost the same as one of the getter.
We could move it to the field and leverage `@see` for people who want to
know about details.
For example:
```java
/**
* A boolean indicating if the alter partition reassignments should be
* allowed to alter the replication factor of a partition.
* In cases where it is not allowed, any replication factor change will
result in an exception thrown by the API.
*/
private boolean allowReplicationFactorChange = true;
/**
* @see AlterPartitionReassignmentsOptions#allowReplicationFactorChange
*/
public boolean allowReplicationFactorChange(boolean allow) {
this.allowReplicationFactorChange = allow;
return allowReplicationFactorChange;
}
/**
* @see AlterPartitionReassignmentsOptions#allowReplicationFactorChange
*/
public boolean allowReplicationFactorChange() {
return this.allowReplicationFactorChange;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
