brandboat commented on code in PR #18983:
URL: https://github.com/apache/kafka/pull/18983#discussion_r1976657588
##########
clients/src/main/java/org/apache/kafka/clients/admin/AlterPartitionReassignmentsOptions.java:
##########
@@ -28,4 +28,25 @@
*/
@InterfaceStability.Evolving
public class AlterPartitionReassignmentsOptions extends
AbstractOptions<AlterPartitionReassignmentsOptions> {
+
+ private Boolean allowReplicationFactorChange = true;
+
+ /**
+ * Set the option indicating if the alter partition reassignments call
should be
+ * allowed to alter the replication factor of a partition.
+ * In cases where it is not allowed, any replication factor change will
result in an exception thrown by the API.
+ */
Review Comment:
It seems that this follows a pattern used in other xxxOptions, such as
`CreateTopicsOptions.java`, `DeleteTopicsOptions.java`, and
`DescribeClusterOptions.java`, etc. While modifying it could help reduce
repetition in the description, I prefer to keep it as is to maintain
consistency with other xxxOptions. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
