AndrewJSchofield commented on code in PR #18963:
URL: https://github.com/apache/kafka/pull/18963#discussion_r1973200080
##########
tools/src/main/java/org/apache/kafka/tools/ShareConsumerPerformance.java:
##########
@@ -79,7 +79,8 @@ public static void main(String[] args) {
shareConsumers.forEach(shareConsumer ->
shareConsumersMetrics.add(shareConsumer.metrics()));
}
shareConsumers.forEach(shareConsumer -> {
- Map<TopicIdPartition, Optional<KafkaException>> val =
shareConsumer.commitSync();
+ @SuppressWarnings("UnusedLocalVariable")
+ Map<TopicIdPartition, Optional<KafkaException>> ignored =
shareConsumer.commitSync();
Review Comment:
This is OK with me in this case. It's just making sure that any in-flight
acknowledgements are committed before the consumer is closed in a performance
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
