chia7712 commented on code in PR #19019:
URL: https://github.com/apache/kafka/pull/19019#discussion_r1973272253
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -82,16 +83,6 @@ object DynamicBrokerConfig {
private[server] val DynamicSecurityConfigs =
SslConfigs.RECONFIGURABLE_CONFIGS.asScala
private[server] val DynamicProducerStateManagerConfig =
Set(TransactionLogConfig.PRODUCER_ID_EXPIRATION_MS_CONFIG,
TransactionLogConfig.TRANSACTION_PARTITION_VERIFICATION_ENABLE_CONFIG)
- val AllDynamicConfigs = DynamicSecurityConfigs ++
- LogCleaner.ReconfigurableConfigs ++
Review Comment:
Could you please move `ReconfigurableConfigs` to `CleanerConfig`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
