chia7712 commented on code in PR #19019:
URL: https://github.com/apache/kafka/pull/19019#discussion_r1976698762
##########
clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java:
##########
@@ -196,6 +198,20 @@ public class SaslConfigs {
public static final boolean DEFAULT_SASL_OAUTHBEARER_HEADER_URLENCODE =
false;
public static final String SASL_OAUTHBEARER_HEADER_URLENCODE_DOC = "The
(optional) setting to enable the OAuth client to URL-encode the client_id and
client_secret in the authorization header"
+ " in accordance with RFC6749, see <a
href=\"https://datatracker.ietf.org/doc/html/rfc6749#section-2.3.1\";>here</a>
for more details. The default value is set to 'false' for backward
compatibility";
+
+ public static final Set<String> RECONFIGURABLE_CONFIGS = Set.of(
Review Comment:
`SaslConfigs.java` is public, so maybe we can move this set to
`DynamicConfig`?
##########
clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java:
##########
@@ -153,6 +153,24 @@ public static void addClientSslSupport(ConfigDef config) {
SslConfigs.SSL_KEYSTORE_CERTIFICATE_CHAIN_CONFIG,
SslConfigs.SSL_KEYSTORE_KEY_CONFIG,
SslConfigs.SSL_TRUSTSTORE_CERTIFICATES_CONFIG);
+
+ public static final Set<String> DYNAMIC_LISTENER_CONFIGS = Set.of(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
