Rancho-7 commented on code in PR #18966: URL: https://github.com/apache/kafka/pull/18966#discussion_r1974984330
########## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ########## @@ -138,6 +138,50 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegrationTest { assertEquals(configEntries, quotaEntities.get(entity).asScala) } + @Test + def testDefaultNameQuotaIsNotEqualToDefaultQuota(): Unit = { + val config = createConfig + val defaultQuota = "<default>" + client = Admin.create(config) + + val userEntity = new ClientQuotaEntity(Map(ClientQuotaEntity.USER -> defaultQuota).asJava) + val clientEntity = new ClientQuotaEntity(Map(ClientQuotaEntity.CLIENT_ID -> defaultQuota).asJava) + + val userAlterations = new ClientQuotaAlteration(userEntity, + Collections.singleton(new ClientQuotaAlteration.Op("consumer_byte_rate", 10000D))) + val clientAlterations = new ClientQuotaAlteration(clientEntity, + Collections.singleton(new ClientQuotaAlteration.Op("producer_byte_rate", 10000D))) + val alterations = List(userAlterations, clientAlterations) + val result = client.alterClientQuotas(alterations.asJava) + result.all().get() + + val values = result.values() Review Comment: Thanks for the review! I will remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org