Rancho-7 commented on code in PR #18966:
URL: https://github.com/apache/kafka/pull/18966#discussion_r1976528793


##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -138,6 +138,67 @@ class PlaintextAdminIntegrationTest extends 
BaseAdminIntegrationTest {
     assertEquals(configEntries, quotaEntities.get(entity).asScala)
   }
 
+  @Test
+  def testDefaultNameQuotaIsNotEqualToDefaultQuota(): Unit = {
+    val config = createConfig
+    val defaultQuota = "<default>"
+    client = Admin.create(config)
+
+    //"<default>" can not create default quota
+    val userEntity = new ClientQuotaEntity(Map(ClientQuotaEntity.USER -> 
defaultQuota).asJava)
+    val clientEntity = new ClientQuotaEntity(Map(ClientQuotaEntity.CLIENT_ID 
-> defaultQuota).asJava)
+    val userAlterations = new ClientQuotaAlteration(userEntity,
+      Collections.singleton(new ClientQuotaAlteration.Op("consumer_byte_rate", 
10000D)))
+    val clientAlterations = new ClientQuotaAlteration(clientEntity,
+      Collections.singleton(new ClientQuotaAlteration.Op("producer_byte_rate", 
10000D)))
+    val alterations = List(userAlterations, clientAlterations)
+    client.alterClientQuotas(alterations.asJava).all().get()
+
+    val values = client.alterClientQuotas(alterations.asJava).values()

Review Comment:
   Sorry,my bad,I have a missunderstanding about `alterClientQuotas` api,and I 
will fix it soon.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to