kirktrue commented on code in PR #19056: URL: https://github.com/apache/kafka/pull/19056#discussion_r1975850054
########## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java: ########## @@ -27,6 +27,8 @@ * A key/value pair to be received from Kafka. This also consists of a topic name and * a partition number from which the record is being received, an offset that points * to the record in a Kafka partition, and a timestamp as marked by the corresponding ProducerRecord. + * + * This class is not thread-safe! Review Comment: Agreed. I think it could do with a little bit more explanation, too. The JavaDoc on [`KafkaConsumer`](https://kafka.apache.org/39/javadoc/org/apache/kafka/clients/consumer/KafkaConsumer.html#multithreaded) is pretty extensive, so maybe that could be referenced? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
