janchilling commented on code in PR #18752:
URL: https://github.com/apache/kafka/pull/18752#discussion_r1976669884
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateUpdateTask.java:
##########
@@ -138,6 +139,7 @@ public void flushState() {
}
public void close(final boolean wipeStateStore) throws IOException {
+ this.flushState();
Review Comment:
Ohh! Thanks for pointing that out. It does seem unnecessary to call
`flushState()` when `wipeStateStore == true` since the state will be deleted
anyway.
I've updated the code to only `flushState()` when `wipeStateStore == false`
from the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
