janchilling commented on code in PR #18752: URL: https://github.com/apache/kafka/pull/18752#discussion_r1976670098
########## streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateTaskTest.java: ########## @@ -333,4 +343,21 @@ public void shouldWipeGlobalStateDirectory() throws Exception { globalStateTask.close(true); assertFalse(stateMgr.baseDir().exists()); } + + @Test + public void shouldCheckpointDuringInitialization() { + globalStateTask.initialize(); + + assertTrue(stateMgr.checkpointWritten); + assertTrue(stateMgr.flushed); + } + + @Test + public void shouldCheckpointDuringClose() throws Exception { + globalStateTask.initialize(); + globalStateTask.close(false); Review Comment: Yeah missed it, now updated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org