AndrewJSchofield commented on code in PR #17264:
URL: https://github.com/apache/kafka/pull/17264#discussion_r1976733882
##########
core/src/main/scala/kafka/server/ConfigHelper.scala:
##########
@@ -210,6 +201,28 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
.setDocumentation(configDocumentation).setConfigType(dataType.id)
}
+ private def createClientMetricsConfigEntry(clientMetricsConfig:
ClientMetricsConfigs, clientMetricsProps: Properties, includeSynonyms: Boolean,
includeDocumentation: Boolean)
+ (name: String, value: Any):
DescribeConfigsResponseData.DescribeConfigsResourceResult = {
+ val configEntryType = ClientMetricsConfigs.configType(name).asScala
+ val valueAsString = ConfigDef.convertToString(value,
configEntryType.orNull)
+ val allSynonyms = {
+ if (!clientMetricsProps.containsKey(name)) {
+ Nil
Review Comment:
I do write Scala like a tourist :) Seems like a sensible suggestion. I'll
push a new commit tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
