AndrewJSchofield commented on code in PR #17264:
URL: https://github.com/apache/kafka/pull/17264#discussion_r1977096640
##########
server/src/test/java/org/apache/kafka/server/metrics/ClientMetricsTestUtils.java:
##########
@@ -40,18 +40,18 @@ public class ClientMetricsTestUtils {
public static final String DEFAULT_METRICS =
"org.apache.kafka.client.producer.partition.queue.,org.apache.kafka.client.producer.partition.latency";
- public static final int DEFAULT_PUSH_INTERVAL_MS = 30 * 1000; // 30 seconds
- public static final List<String> DEFAULT_CLIENT_MATCH_PATTERNS = List.of(
+ public static final int DEFAULT_INTERVAL_MS = 30 * 1000; // 30 seconds
Review Comment:
I've changed the naming but because these are not the true default, but the
defaults for the test, I used `_TEST_DEFAULT` in the names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
