azhar2407 commented on code in PR #19099:
URL: https://github.com/apache/kafka/pull/19099#discussion_r1980699907
##########
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##########
@@ -482,6 +482,30 @@ class DynamicBrokerReconfigurationTest extends
QuorumTestHarness with SaslSetup
waitForAuthenticationFailure(producerBuilder.keyStoreProps(sslProperties1))
}
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+ @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
+ def testSocketServerConfigTest(quorum: String, groupProtocol: String): Unit
= {
+ val updatedMaxConnections = "20"
+ val ConnectionsIpsOverride = "1.2.3.4:1234,1.2.4.5:2345"
Review Comment:
seems like a typo. Do you think this prevents the PR merge? Sorry I am new a
contributor, trying to understand if this requires a fresh revision?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
