frankvicky commented on code in PR #19099:
URL: https://github.com/apache/kafka/pull/19099#discussion_r1980768166


##########
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##########
@@ -482,6 +482,30 @@ class DynamicBrokerReconfigurationTest extends 
QuorumTestHarness with SaslSetup
     waitForAuthenticationFailure(producerBuilder.keyStoreProps(sslProperties1))
   }
 
+  @ParameterizedTest(name = 
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+  @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
+  def testSocketServerConfigTest(quorum: String, groupProtocol: String): Unit 
= {
+    val updatedMaxConnections = "20"
+    val ConnectionsIpsOverride = "1.2.3.4:1234,1.2.4.5:2345"

Review Comment:
   No worries.
   Although it's not a big issue, I suggest you fix the typo, and welcome to 
Kafka 😺 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to