mumrah commented on code in PR #19113:
URL: https://github.com/apache/kafka/pull/19113#discussion_r1982166952
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java:
##########
@@ -1062,6 +1065,24 @@ private void ensureExplicitAcknowledgement() {
}
}
+ /**
+ * Initializes the acknowledgement mode based on the configuration.
+ */
+ private static AcknowledgementMode
initializeAcknowledgementMode(ConsumerConfig config) {
+ if (config == null) {
+ return AcknowledgementMode.UNKNOWN;
+ }
+ String acknowledgementModeStr =
config.getString(ConsumerConfig.INTERNAL_SHARE_ACKNOWLEDGEMENT_MODE_CONFIG);
+ if ((acknowledgementModeStr == null) ||
acknowledgementModeStr.isEmpty()) {
+ return AcknowledgementMode.UNKNOWN;
+ } else if (acknowledgementModeStr.equalsIgnoreCase("implicit")) {
+ return AcknowledgementMode.IMPLICIT;
+ } else if (acknowledgementModeStr.equalsIgnoreCase("explicit")) {
+ return AcknowledgementMode.EXPLICIT;
+ }
+ return AcknowledgementMode.UNKNOWN;
Review Comment:
Is it worth logging a warning if an unsupported value is given?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
