AndrewJSchofield commented on PR #19113: URL: https://github.com/apache/kafka/pull/19113#issuecomment-2703259224
> The new config looks good, just one comment inline. > > Few questions (probably beyond the scope of this PR): > > 1. If implicit acks are configured, would calling the acknowledge method throw a runtime exception? > 2. If explicit acks are configured, will offsets ever get automatically acknowledged? > 3. Have we consider a separate interface for implicit acks? One that doesn't even expose the methods? Thanks for the review. 1. Yes, it throws `IllegalStateException` and there's a test for this. 2. That is going to be investigated in the next PR. Right now, no, never automatically acknowledged. But the behaviour for unacknowledged records when explicit acks are being used is another area I'm looking into. Except another PR in this area soon. What I expect to do is reach a decision on both of these areas and finalise in the next couple of weeks. 3. No, I hadn't considered that. I suppose we could have a subclass of `KafkaShareConsumer` which adds the `acknowledge` method. I'll think about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
