cmccabe commented on PR #18685: URL: https://github.com/apache/kafka/pull/18685#issuecomment-2704663862
It looks like we both created PRs around the same time to fix this bug. Mine is here : https://github.com/apache/kafka/pull/19127 . Some thoughts: - It is true that FeaturesPublisher is kind of redundant now with the metadata cache. The reason why it was this way is that originally the controller didn't create the metadata cache. I guess it's OK to remove FeaturesPublisher. - While I understand why you did it, moving kraft.version out of BootstrapMetadata in tests feels messy to me. I think we should leave this alone for now and think about it more in the future. Perhaps surfacing the initial raft state in BootstrapMetadata.java is possible. That would be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
