FrankYang0529 commented on code in PR #18685:
URL: https://github.com/apache/kafka/pull/18685#discussion_r1984276852
##########
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##########
@@ -522,10 +522,14 @@ class KRaftMetadataCache(
if (kraftVersionLevel > 0) {
finalizedFeatures.put(KRaftVersion.FEATURE_NAME, kraftVersionLevel)
}
+ var metadataVersion = MetadataVersion.MINIMUM_VERSION
Review Comment:
@cmccabe If we don't add `MINIMUM_VERSION` here, we get failed test case
like `ReconfigurableQuorumIntegrationTest#testRemoveController`. Failed cases
in this
https://github.com/apache/kafka/actions/runs/13694313653/job/38293530484 are
related to this.
I got error message like
```
[2025-03-07 09:38:36,355] WARN [RaftManager id=3001] Received error
UNKNOWN_SERVER_ERROR from node 3002 when making an ApiVersionsRequest with
correlation id 916. Disconnecting. (org.apache.kafka.clients.NetworkClient:1028)
[2025-03-07 09:38:36,436] ERROR [ControllerApis nodeId=3001] Unexpected
error handling request RequestHeader(apiKey=API_VERSIONS, apiVersion=4,
clientId=raft-client-3000, correlationId=872, headerVersion=2) --
ApiVersionsRequestData(clientSoftwareName='apache-kafka-java',
clientSoftwareVersion='4.1.0-SNAPSHOT') with context
RequestContext(header=RequestHeader(apiKey=API_VERSIONS, apiVersion=4,
clientId=raft-client-3000, correlationId=872, headerVersion=2),
connectionId='127.0.0.1:59302-127.0.0.1:60038-1-81', clientAddress=/127.0.0.1,
principal=User:ANONYMOUS, listenerName=ListenerName(CONTROLLER),
securityProtocol=PLAINTEXT,
clientInformation=ClientInformation(softwareName=unknown,
softwareVersion=unknown), fromPrivilegedListener=false,
principalSerde=Optional[org.apache.kafka.common.security.authenticator.DefaultKafkaPrincipalBuilder@5d65541f])
(kafka.server.ControllerApis:79)
java.lang.IllegalStateException: Unknown metadata version for FeaturesImage:
metadataVersion(Optional.empty), zkMigrationState()
at
org.apache.kafka.image.FeaturesImage.lambda$metadataVersionOrThrow$0(FeaturesImage.java:73)
~[kafka-metadata-4.1.0-SNAPSHOT.jar:?]
at java.base/java.util.Optional.orElseThrow(Optional.java:403) ~[?:?]
at
org.apache.kafka.image.FeaturesImage.metadataVersionOrThrow(FeaturesImage.java:72)
~[kafka-metadata-4.1.0-SNAPSHOT.jar:?]
at
kafka.server.metadata.KRaftMetadataCache.features(KRaftMetadataCache.scala:530)
~[main/:?]
at
kafka.server.ControllerServer.$anonfun$startup$8(ControllerServer.scala:152)
~[main/:?]
at
kafka.server.SimpleApiVersionManager.features(ApiVersionManager.scala:115)
~[main/:?]
at
kafka.server.SimpleApiVersionManager.apiVersionResponse(ApiVersionManager.scala:103)
~[main/:?]
at
kafka.server.ControllerApis.$anonfun$handleApiVersionsRequest$3(ControllerApis.scala:464)
~[main/:?]
at
kafka.server.ControllerApis.$anonfun$handleApiVersionsRequest$3$adapted(ControllerApis.scala:464)
~[main/:?]
at
kafka.server.RequestHandlerHelper.sendResponseMaybeThrottle(RequestHandlerHelper.scala:99)
~[main/:?]
at
kafka.server.ControllerApis.handleApiVersionsRequest(ControllerApis.scala:464)
~[main/:?]
at kafka.server.ControllerApis.handle(ControllerApis.scala:100)
~[main/:?]
at kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:158)
~[main/:?]
at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
