chia7712 commented on code in PR #19144:
URL: https://github.com/apache/kafka/pull/19144#discussion_r1985569125
##########
build.gradle:
##########
@@ -1960,6 +1960,29 @@ project(':clients') {
}
}
+project(':clients:integration-tests') {
+ base {
+ archivesName = "kafka-clients-integration-tests"
+ }
+
+ dependencies {
+ testImplementation libs.slf4jApi
+ testImplementation project(':clients')
Review Comment:
we don't need to declare it explicitly, right?
##########
settings.gradle:
##########
@@ -64,6 +64,7 @@ buildCache {
}
include 'clients',
+ 'clients:integration-tests',
Review Comment:
should we use `clients-integration-tests` to avoid potential conflict
(https://github.com/gradle/gradle/issues/847) with `streams:integration-tests`?
##########
clients/integration-tests/src/test/java/org/apache/kafka/clients/admin/AdminClientRebootstrapTest.java:
##########
@@ -72,10 +73,17 @@ private static ClusterConfig buildConfig(Map<String,
String> serverProperties, M
.setServerProperties(serverProperties).build();
}
+ private boolean containsTopic(Admin admin, String topic) {
+ try {
Review Comment:
```java
return Assertions.assertDoesNotThrow(() ->
admin.listTopics().names().get(60, TimeUnit.SECONDS).contains(topic));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
