ahuang98 commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1985705585
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##########
@@ -276,16 +281,16 @@ public void testListenerRenotified(boolean withKip853Rpc)
throws Exception {
}
@ParameterizedTest
- @ValueSource(booleans = { false, true })
- public void testLeaderImmediatelySendsSnapshotId(boolean withKip853Rpc)
throws Exception {
+ @EnumSource(value = RaftProtocol.class)
Review Comment:
we should have probably picked the same strategy for
KafkaRaftClientSnapshotTest and KafkaRaftClientTest (either test all protocols
for both tests or directly translate to matrix of KIP_595 and KIP_853)
I'm not sure if it's a big enough deal to ask you to standardize though -
@jsancio thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
