frankvicky commented on code in PR #18600: URL: https://github.com/apache/kafka/pull/18600#discussion_r1990879080
########## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ########## @@ -92,25 +97,25 @@ public void testNodeDirectoryId() { } @ParameterizedTest - @ValueSource(booleans = { true, false }) - public void testInitializeSingleMemberQuorum(boolean withKip853Rpc) throws IOException { + @EnumSource(value = RaftProtocol.class, names = {"KIP_595_PROTOCOL", "KIP_853_PROTOCOL"}) Review Comment: Please ignore the above comment. I tried to enable all raft protocols for `KafkaRaftClientTest`, and all tests passed. I will include this change in the next commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org