chia7712 commented on code in PR #19194:
URL: https://github.com/apache/kafka/pull/19194#discussion_r1997663945
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -330,7 +327,7 @@ def __init__(self, context, num_nodes, zk,
security_protocol=SecurityConfig.PLAI
if self.quorum_info.has_brokers:
num_nodes_broker_role = num_nodes
if self.quorum_info.has_controllers:
- self.num_nodes_controller_role =
self.num_kraft_controllers(num_nodes_broker_role, controller_num_nodes_override)
+ self.num_nodes_controller_role =
self.num_kraft_controllers(num_nodes_broker_role, 0)
Review Comment:
Pardon me, can assigning the value to `0` address the "Propose to set the
controller node to at least 3"? It seems to me, it still depend on the
`num_nodes_broker_role`, right?
```
if num_nodes_broker_role < 3:
return 1
if num_nodes_broker_role < 5:
return 3
return 5
```
https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/kafka/kafka.py#L495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
