chia7712 commented on code in PR #19194:
URL: https://github.com/apache/kafka/pull/19194#discussion_r2004167256


##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -330,7 +327,7 @@ def __init__(self, context, num_nodes, zk, 
security_protocol=SecurityConfig.PLAI
             if self.quorum_info.has_brokers:
                 num_nodes_broker_role = num_nodes
                 if self.quorum_info.has_controllers:
-                    self.num_nodes_controller_role = 
self.num_kraft_controllers(num_nodes_broker_role, controller_num_nodes_override)
+                    self.num_nodes_controller_role = 
self.num_kraft_controllers(num_nodes_broker_role, 0)

Review Comment:
   I may be mistaken, but I understand this pull request to be intended to 
increase the number of controller nodes, thereby preventing a complete 
controller service outage during a rolling bounce. Is that correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to