chia7712 commented on code in PR #17322:
URL: https://github.com/apache/kafka/pull/17322#discussion_r2004253095
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1658,6 +1706,26 @@ private long findLastOffsetAcknowledged() {
return lastOffsetAcknowledged;
}
+ /**
+ * Find the last offset from the batch which contains the request offset.
If found, return the last offset
+ * of the batch, otherwise return the request offset.
+ *
+ * @param batches The batches to search for the request offset.
+ * @param offset The request offset to find.
+ * @return The last offset of the batch which contains the request offset,
otherwise the request offset.
+ */
+ private long findLastOffsetFromBatchWithRequestOffset(
+ Iterable<? extends RecordBatch> batches,
+ long offset
+ ) {
+ for (RecordBatch batch : batches) {
+ if (offset >= batch.baseOffset() && offset <= batch.lastOffset()) {
Review Comment:
> but not optimizing if lastOffset of the batch can somehow be pre-loaded
with loading headers?
Given that lastOffsetDelta is located at byte 23, it necessitates seeking
the file channel to read specific bytes. Furthermore, we may iterate through
numerous batches if the index is sparse. I'm uncertain whether incurring this
cost is justified. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
