mingyen066 commented on code in PR #19177: URL: https://github.com/apache/kafka/pull/19177#discussion_r2009010075
########## server/src/main/java/org/apache/kafka/server/Assignment.java: ########## @@ -57,6 +96,23 @@ boolean valid(int nodeId, MetadataImage image) { return Replicas.contains(partition.replicas, nodeId); } + @Override + public boolean equals(Object o) { Review Comment: Confirm that `Assignment` is not used in Map/Set key. Remove equals method from `Assignment` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org