mingyen066 commented on code in PR #19177:
URL: https://github.com/apache/kafka/pull/19177#discussion_r2019770203


##########
raft/src/main/java/org/apache/kafka/raft/LogFetchInfo.java:
##########
@@ -21,4 +21,13 @@
 /**
  * Metadata for the records fetched from log, including the records itself
  */
-public record LogFetchInfo(Records records, LogOffsetMetadata 
startOffsetMetadata) { }
+public class LogFetchInfo {

Review Comment:
   comment added



##########
server/src/main/java/org/apache/kafka/server/Assignment.java:
##########
@@ -24,25 +24,62 @@
 import org.apache.kafka.metadata.Replicas;
 import org.apache.kafka.server.common.TopicIdPartition;
 
-/**
- * @param topicIdPartition The topic ID and partition index of the replica.
- * @param directoryId      The ID of the directory we are placing the replica 
into.
- * @param submissionTimeNs The time in monotonic nanosecond when this 
assignment was created.
- * @param successCallback  The callback to invoke on success.
- */
-record Assignment(
-    TopicIdPartition topicIdPartition,
-    Uuid directoryId,
-    long submissionTimeNs,
-    Runnable successCallback
-) {
+final class Assignment {

Review Comment:
   comment added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to