AndrewJSchofield commented on code in PR #19343:
URL: https://github.com/apache/kafka/pull/19343#discussion_r2023172343
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##########
@@ -200,4 +200,11 @@ void validateOffsetFetch(
* Requests a metadata refresh.
*/
void requestMetadataRefresh();
+
+ /**
+ * Returns whether this group should be expired or not
+ *
+ * @return whether the group should be expired
+ */
+ boolean shouldExpire();
Review Comment:
You could have a default implementation that returns true so it's not
necessary to put identical implementations in all of the subclasses which do
not override.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
