AndrewJSchofield commented on code in PR #19343:
URL: https://github.com/apache/kafka/pull/19343#discussion_r2023410435
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorShardTest.java:
##########
@@ -1463,6 +1473,41 @@ public void testCleanupGroupMetadata() {
verify(groupMetadataManager,
times(0)).maybeDeleteGroup(eq("other-group-id"), any());
}
+ @Test
+ public void testCleanupGroupMetadataForShareGroup() {
+ GroupMetadataManager groupMetadataManager =
mock(GroupMetadataManager.class);
+ OffsetMetadataManager offsetMetadataManager =
mock(OffsetMetadataManager.class);
+ Time mockTime = new MockTime();
+ MockCoordinatorTimer<Void, CoordinatorRecord> timer = new
MockCoordinatorTimer<>(mockTime);
+ GroupCoordinatorShard coordinator = new GroupCoordinatorShard(
+ new LogContext(),
+ groupMetadataManager,
+ offsetMetadataManager,
+ mockTime,
+ timer,
+ mock(GroupCoordinatorConfig.class),
+ mock(CoordinatorMetrics.class),
+ mock(CoordinatorMetricsShard.class)
+ );
+
+ SnapshotRegistry snapshotRegistry = new SnapshotRegistry(new
LogContext());
+ ShareGroup group = new ShareGroup(snapshotRegistry, "group-id");
+
+ when(groupMetadataManager.groupIds()).thenReturn(Set.of("group-id"));
+ when(groupMetadataManager.group("group-id")).thenReturn(group);
+
+ assertFalse(timer.contains(GROUP_EXPIRATION_KEY));
+ CoordinatorResult<Void, CoordinatorRecord> result =
coordinator.cleanupGroupMetadata();
+ assertTrue(timer.contains(GROUP_EXPIRATION_KEY));
+
+ List<CoordinatorRecord> expectedRecords = List.of();
+ assertEquals(expectedRecords, result.records());
+ assertNull(result.response());
+ assertNull(result.appendFuture());
+
+ verify(groupMetadataManager, times(1)).groupIds();
+ }
Review Comment:
You could verify 0 calls to `offsetMetadataManager.cleanupExpiredOffsets`
and `groupMetadataManager.maybeDeleteGroup`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
